Skip to content

Make snippet-extract take individual input/output files instead of a directory #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bitjammer
Copy link
Contributor

This does not change the experience for package authors but allows for better integration with other tools that require sandboxing of file access.

rdar://103034070

  • Added tests
  • Ran the ./bin/test script and it succeeded
  • Updated documentation if necessary

@bitjammer bitjammer force-pushed the acgarland/rdar-103034070-snippet-extract-individual-files branch from 62e4dd6 to 9c700b0 Compare December 8, 2022 20:40
@bitjammer
Copy link
Contributor Author

@swift-ci Please test

@bitjammer
Copy link
Contributor Author

Hm... ./bin/test succeeds here locally. Going to run again in case it's a bot issue.

@bitjammer
Copy link
Contributor Author

@swift-ci Please test

@bitjammer bitjammer force-pushed the acgarland/rdar-103034070-snippet-extract-individual-files branch from 9c700b0 to 509a7b3 Compare December 16, 2022 00:31
@bitjammer
Copy link
Contributor Author

@swift-ci Please test

Copy link
Contributor

@ethan-kusters ethan-kusters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bitjammer bitjammer force-pushed the acgarland/rdar-103034070-snippet-extract-individual-files branch from 6a6ff8a to 7f6b3da Compare December 16, 2022 21:09
…directory

This does not change the experience for package authors but allows for better
integration with other tools that require sandboxing of file access.

rdar://103034070
@bitjammer bitjammer force-pushed the acgarland/rdar-103034070-snippet-extract-individual-files branch from 7f6b3da to d3130d1 Compare December 16, 2022 21:10
@bitjammer
Copy link
Contributor Author

@swift-ci Please test

@bitjammer bitjammer merged commit e013865 into swiftlang:main Dec 16, 2022
@bitjammer bitjammer deleted the acgarland/rdar-103034070-snippet-extract-individual-files branch December 16, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants