[AX] <table> should be taken out of <figure> and the <figcaption> should become the table’s <caption> #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
dobromir-hristov
approved these changes
Jan 5, 2022
Co-authored-by: Dobromir Hristov <[email protected]>
|
@swift-ci please test |
|
@swift-ci test |
dobromir-hristov
approved these changes
May 23, 2023
| @@ -53,4 +58,8 @@ export default { | |||
| /deep/ p { | |||
| display: inline-block; | |||
| } | |||
|
|
|||
| caption { | |||
There was a problem hiding this comment.
I guess this is less of a concern, but if caption-side: bottom; is applied, this styling will not work as expected. However I am not sure how to check that with pure CSS. MDN jus suggest using padding around the caption...
There was a problem hiding this comment.
After investigating it, I also didn't find a way of checking if caption is on top or bottom so I applied a generic margin: 0fe3af6
|
@swift-ci test |
3 tasks
mportiz08
added a commit
to mportiz08/swift-docc-render
that referenced
this pull request
Jun 2, 2023
…ion> should become the table’s <caption> (swiftlang#40)" This reverts commit 81138c8.
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #30234820, if applicable:
Summary
Tables were contained within a
<figure>element. However, there is no need for this and it was making the tables much less accessible. Tables should stand on their own with the previous<figcaption>as the table’s<caption>.Dependencies
NA
Testing
Use the provided fixture folder:
manual-fixtures.zip
Steps:
VUE_APP_DEV_SERVER_PROXY=/path/to/manual-fixtures/ npm run serveChecklist
npm test, and it succeeded