Skip to content

[AX] Color scheme toggle keyboard navigation should follow radio buttons standards #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

marinaaisa
Copy link
Member

Bug/issue #94221573, if applicable:

Summary

Color scheme toggle keyboard navigation should follow radio buttons standards: https://www.w3.org/WAI/ARIA/apg/example-index/radio/radio.html

radio.mov

Dependencies

NA

Testing

Steps:

  1. Run any doccarchive
  2. Go to footer
  3. Tab and assert that you focus the radio buttons for the Color scheme toggle
  4. Assert that by pressing the arrow keys you can select different color schemes

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

Copy link
Contributor

@dobromir-hristov dobromir-hristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you did some general cleanup along with the change. I think that is fine.

I had the focus-within mixin pending for some time now in, good we are adding it - https://github.com/apple/swift-docc-render/pull/348/files#diff-96c76e12b6abbe6ec6df39ce6b01d2fb4b418d3569baf7dd041536fff6dd2be8

@marinaaisa
Copy link
Member Author

@swift-ci test

@marinaaisa marinaaisa merged commit 2db9e23 into swiftlang:main Aug 3, 2022
@marinaaisa marinaaisa deleted the r94221573/color-scheme-ax branch August 3, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants