Cleanup and improvements to the Navigator #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 24, 2022 14:44
dobromir-hristov
changed the title
added 2 commits
August 29, 2022 19:13
…g to allow no truncation on navigator items.
…-css-var # Conflicts: # tests/unit/components/Navigator/NavigatorCard.spec.js
added 2 commits
September 19, 2022 10:20
…-css-var # Conflicts: # src/components/Navigator/NavigatorCard.vue # tests/unit/components/Navigator.spec.js # tests/unit/components/Navigator/NavigatorCard.spec.js # tests/unit/views/DocumentationTopic.spec.js
|
@swift-ci test |
|
@swift-ci test |
marinaaisa
previously requested changes
Sep 20, 2022
|
@swift-ci test |
mportiz08
approved these changes
Sep 21, 2022
|
@swift-ci test |
|
@swift-ci test |
dobromir-hristov
deleted the
dhristov/r97716711-move-navigator-spacing-to-css-var
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 97716711
Summary
This PR refactors the Navigator to make it more robust and cleans up the styling.
Dependencies
NA
Testing
Steps:
Navigator.vuewhitespace: nowrapso titles overflow. Assert the navigator works as expected.Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded