Fix navigator filter getting cutoff #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mportiz08
approved these changes
Aug 30, 2022
|
@swift-ci test |
dobromir-hristov
deleted the
dhristov/r99316400-fix-navigator-filter-cutoff
branch
dobromir-hristov
pushed a commit
to dobromir-hristov/swift-docc-render
that referenced
this pull request
Sep 7, 2022
closes rdar://99316400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 99316400
Summary
Fixes an issue where the navigator filter gets cutoff when you expand a few items in the Navigator.
This happens because we were trying to catch transition events the adjustable sidebar in order to apply some extra styling mid transition. However, those event listeners would also catch deep child events as well, which was causing the bug.
A good practice with
transitionstartevent is to use the.selfmodifier, which I totally forgot.Dependencies
NA
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded