Skip to content

Use Reference for NavMenuLink #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/components/NavMenuLink.vue
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,23 @@
>
<slot />
</span>
<router-link
<Reference
v-else
class="nav-menu-link"
:to="url"
:url="url"
tabindex="0"
>
<slot />
</router-link>
</Reference>
</template>

<script>
import { buildUrl } from 'docc-render/utils/url-helper';
import Reference from 'docc-render/components/ContentNode/Reference.vue';

export default {
name: 'NavMenuLink',
components: { Reference },
computed: {
isCurrent: ({ $route, url }) => ((typeof url === 'string') ? (
// Use the `buildUrl` to compare urls, as we dont want to compare unnecessary query params
Expand Down
15 changes: 7 additions & 8 deletions tests/unit/components/NavMenuLink.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
*/

import NavMenuLink from 'docc-render/components/NavMenuLink.vue';
import { RouterLinkStub, shallowMount } from '@vue/test-utils';
import { shallowMount } from '@vue/test-utils';
import Reference from '@/components/ContentNode/Reference.vue';

const mountItem = attrs => shallowMount(NavMenuLink, {
stubs: { RouterLinkStub },
...attrs,
});

Expand Down Expand Up @@ -50,18 +50,17 @@ describe('NavMenuLink', () => {
expect(wrapper.find('span.nav-menu-link').classes()).toContain('current');
});

it('renders a <router-link> for local routes', () => {
it('renders a <Reference> for local routes', () => {
const wrapper = mountItem({
propsData: { url: { name: 'blah' } },
mocks: { $route: { name: 'foobar' } },
stubs: { 'router-link': RouterLinkStub },
propsData: { url: '/foo/bar' },
mocks: { $route: { path: '/foo/baz', query: {} } },
slots: { default: 'Blah' },
});

const link = wrapper.find(RouterLinkStub);
const link = wrapper.find(Reference);
expect(link.exists()).toBe(true);
expect(link.classes('nav-menu-link')).toBe(true);
expect(link.props('to')).toEqual({ name: 'blah' });
expect(link.props('url')).toEqual('/foo/bar');
expect(link.text()).toBe('Blah');
});
});