Skip to content

Remove unnecessary background color override for legal text #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

mportiz08
Copy link
Contributor

Bug/issue #, if applicable: 99979298

Summary

Removes an old background color override that used to be necessary with a previous layout design (pre sidebar) but is no longer needed now since the "Topics" section always has the same background color now.

Testing

Steps:

  1. Find pages with beta content, ideally both examples with a "Topics" section and also one without a "Topics" section.
  2. Verify that the background color for the "Beta Software" element is always using the same secondary fill color.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests (CSS only change)
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

Copy link
Contributor

@dobromir-hristov dobromir-hristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mportiz08
Copy link
Contributor Author

@swift-ci test

1 similar comment
@mportiz08
Copy link
Contributor Author

@swift-ci test

@mportiz08 mportiz08 merged commit 110f26a into swiftlang:main Sep 19, 2022
@mportiz08 mportiz08 deleted the simplify-beta-legal-text-bg-fill branch September 19, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants