[5.9] Update reference to renamed font style #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mportiz08
commented
Jun 1, 2023
mportiz08
commented
- Explanation: Fixes issue where a font-style was renamed but a reference to the old name was not properly updated, resulting in unexpectedly large text for figure captions.
- Scope: Impacts any caption for a figure.
- Issue: rdar://110085109
- Risk: Low, single word/argument change
- Testing: Verified that warning is no longer emitted in console and verified that caption text is back to its expected size.
- Reviewer: @dobromir-hristov
- Original PR: Update reference to renamed font style #683
Resolves: rdar://110085109
eango
approved these changes
Jun 1, 2023
|
@swift-ci test |
mportiz08
added a commit
to mportiz08/swift-docc-render
that referenced
this pull request
Jun 2, 2023
…tlang#686)" This reverts commit 69381ab.
mportiz08
added a commit
that referenced
this pull request
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.