Aria-label that indicates scrolling behaviour interferes in headings content for screen readers #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
mportiz08
reviewed
Jun 26, 2023
| :id="anchor" | ||
| :is="`h${level}`" | ||
| > | ||
| <div class="heading-wrapper"> |
There was a problem hiding this comment.
One downside to this restructuring of elements is that now you have to click the actual icon in order to get the link for the heading whereas before you could click anywhere within the title itself, which seemed like a better experience to me.
Is there a way of keeping that same behavior as before while also addressing the screen reader issue?
There was a problem hiding this comment.
I took another approach and I continued with the previous experience. So the change isn't too much f9ce461
marinaaisa
force-pushed
the
r111006953/headings-screen-readers
branch
from
80e76a4 to
f9ce461
Compare
mportiz08
requested changes
Jun 27, 2023
|
@swift-ci test |
mportiz08
approved these changes
Jun 27, 2023
marinaaisa
added a commit
to marinaaisa/swift-docc-render
that referenced
this pull request
Jun 28, 2023
…content for screen readers (swiftlang#698) Resolves: rdar://111006953
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #111006953, if applicable:
Summary
Aria-label that indicates scrolling behaviour interferes in headings content for screen readers
It's been fixed by restructuring how the anchor link is set and adding AX description that should read: Content of heading + "in page link" to describe that the link is within the page.
Dependencies
NA
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded