Other declaration pills should be clickable when there are changes data #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the DeclarationGroup/List logic
pill shouldn't be selected if the list is in expanded state
Fix background color of selected pill & clean up css
improve animation for long decl list: 1. bump to top of page first 2. decrease wait time
remove unnecessary checks in `Declaration` test
add test for `DeclarationGroup`
fix changes class for decl without other decls
fix modified declaration with no other decl
Add test for `DeclarationList`
Update test for `DeclarationDiff`
|
@swift-ci test |
chore: remove extra empty line
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
do not highlight diff in collapsed state
|
@swift-ci test |
mportiz08
approved these changes
Jun 25, 2024
| @@ -17,7 +17,6 @@ | |||
| :key="i" | |||
| :declaration="declaration" | |||
| :should-caption="currentDeclarations.length > 1" | |||
| :changeType="changeType" | |||
There was a problem hiding this comment.
Should we remove changeType as a prop for this component? It doesn't seem like it's being used anymore.
There was a problem hiding this comment.
I think it's still used when we use the DeclarationList component in Declaration.vue
There was a problem hiding this comment.
Ops you meant DeclarationDiff component, not DeclarationList lol
src/components/DocumentationTopic/PrimaryContent/DeclarationGroup.vue
Outdated
Show resolved
Hide resolved
remove `isSwift` prop
|
@swift-ci test |
remove `changeType` prop
|
@swift-ci test |
…hhuang/swift-docc-render into decl-diff-other-decl-button-clickable
|
@swift-ci test |
hqhhuang
added a commit
to hqhhuang/swift-docc-render
that referenced
this pull request
Jun 26, 2024
…ta (swiftlang#832) rdar://127125451 Other declaration pills should be clickable when there are changes data (swiftlang#832) rdar://127125451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://127125451
Summary
Other declaration pills should be clickable when there are changes data, and when the list of other declarations are expanded.
Testing
Steps:
Currently working on writing tests.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded