Skip to content

[6.0] Include code and referenced text in metadata description (#862) #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2024
Merged

[6.0] Include code and referenced text in metadata description (#862) #864

merged 2 commits into from
Jun 18, 2024

Conversation

mportiz08
Copy link
Contributor

  • Explanation: Fixes issue where inline references and code are not included in HTML metadata
  • Scope: Impacts <meta name="description"> tag for any pages with links/code in abstract paragraph
  • Issue: rdar://129801569
  • Risk: Low, small addition to focused logic for generating plaintext content
  • Testing: Added unit tests, manually tested that expected inline text is now being included in metadata and there are no other regressions to metadata for other pages
  • Reviewer: @marinaaisa
  • Original PR: Include code and referenced text in metadata description #862

@mportiz08 mportiz08 requested a review from franklinsch June 17, 2024 16:36
@mportiz08
Copy link
Contributor Author

@swift-ci test

@mportiz08 mportiz08 merged commit 8a367dc into swiftlang:release/6.0 Jun 18, 2024
1 check passed
@mportiz08 mportiz08 deleted the 6.0/include-references-in-plaintext branch June 18, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklinsch franklinsch franklinsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mportiz08 @franklinsch