Include Relationship section in minimized mode #868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show `Relationships` in minimized mode
Fix spacing and move view more link to the bottom
…hips` update tests for `DocumentationTopic`, `ContentTable`, and `Relationships`
fix declaration container margin
mportiz08
reviewed
Jun 24, 2024
mportiz08
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Seems to be working well on a functional level.
As we discussed in person, the code for the "minimized" layout of documentation pages is starting to get pretty spread out and messy, but we may have to refactor things entirely using a new top-level component if we want to clean things up at this point. We may want to consider that in the future if we need to enhance this layout more.
| @@ -44,6 +45,10 @@ export default { | |||
| type: Array, | |||
| required: true, | |||
| }, | |||
| enableMinimized: { | |||
There was a problem hiding this comment.
I don't think you need to change this, but in the future it might be worth considering provide/inject for situations like this where you're adding props to a component solely for the purpose of passing it down to further nested children.
|
@swift-ci test |
hqhhuang
added a commit
to hqhhuang/swift-docc-render
that referenced
this pull request
Jul 3, 2024
…/81022077 Include Relationship section in minimized mode (swiftlang#868) rdar://81022077
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://81022077
Summary
Include Relationship section in minimized mode
Dependencies
NA
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded