[Rebased] Highlight unique components of overloaded declarations [alternate approach] #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
mportiz08
approved these changes
Jun 28, 2024
hqhhuang
added a commit
to hqhhuang/swift-docc-render
that referenced
this pull request
Jun 28, 2024
…roach] (swiftlang#875) rdar://117503463 Highlight unique components of overloaded declarations [alternate approach] (swiftlang#875) rdar://117503463 --------- Co-authored-by: Vera Mitchell <[email protected]> Co-authored-by: Marcus Ortiz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#847 rebased onto main.
Issue: rdar://117503463
This implements the same rendering of highlighted tokens as #841 but using an alternate Render JSON schema where each token may possibly have a
highlightDiffboolean flag instead of introducing a new token kind to represent highlights.I'm not sure yet which approach the DocC team is going to decide on yet, so I'm opening a draft PR for both options and will close one depending on what they decide on.
Testing
Same instructions as #841 except make sure to use the older commit
33388c3c7987904e0aec58e4035fea14bcd19965from the swift-docc branch when building DocC instead of the latest commit from the mentioned branch.