Skip to content

Fix regression where external links are rendering as plaintext #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

mportiz08
Copy link
Contributor

Bug/issue #, if applicable: #885, 133444687

Summary

Fixes a regression introduced by #878 where external links are now rendering as plaintext strings instead of clickable links.

Resolves #885

Testing

Steps:

  1. Checkout this branch and run the dev server with VUE_APP_DEV_SERVER_PROXY=https://jverkoey.github.io/slipstream npm run serve
  2. Open http://localhost:8080/documentation/slipstream/slipstreamforswiftuidevelopers#Stacks and verify that the HStack and VStack strings are clickable links now (compare with main branch where they are plaintext)
  3. Repeat testing instructions from Inactivate known external links #878 to ensure that functionality is not impacted by this change

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

@mportiz08
Copy link
Contributor Author

@swift-ci test

@mportiz08 mportiz08 merged commit 8a8983c into swiftlang:main Aug 9, 2024
1 check passed
@mportiz08 mportiz08 deleted the fix-broken-external-links branch August 9, 2024 16:49
@jverkoey
Copy link

jverkoey commented Aug 9, 2024

Thank you!

@mportiz08
Copy link
Contributor Author

Thanks for catching this and bringing it to our attention @jverkoey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External docc links stopped working in Xcode Version 16.0 beta 5 (16A5221g)
3 participants