Skip to content

Use bash for scripts instead of sh #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

mportiz08
Copy link
Contributor

Bug/issue #, if applicable:

Summary

This fixes a minor issue with some scripts in bin/ that use the shebang line #!/usr/bin/env sh.

When running on a system with an actual sh implementation, these scripts fail due to a syntax issue with the function keyword (apparently a bash specific thing). This is easy to miss on platforms where sh is just a link to bash, so using bash will ensure that the scripts work without changes on all platforms.

Testing

Steps:

  1. Run npm run docs to exercise all these scripts and ensure they are still functional.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

@mportiz08
Copy link
Contributor Author

@swift-ci test

@mportiz08 mportiz08 requested a review from eango August 15, 2024 18:15
@mportiz08 mportiz08 merged commit 1162202 into swiftlang:main Aug 19, 2024
1 check passed
@mportiz08 mportiz08 deleted the use-bash-for-scripts branch August 19, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants