Use bash for scripts instead of sh #888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
This fixes a minor issue with some scripts in
bin/
that use the shebang line#!/usr/bin/env sh
.When running on a system with an actual
sh
implementation, these scripts fail due to a syntax issue with thefunction
keyword (apparently abash
specific thing). This is easy to miss on platforms wheresh
is just a link tobash
, so usingbash
will ensure that the scripts work without changes on all platforms.Testing
Steps:
npm run docs
to exercise all these scripts and ensure they are still functional.Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test
, and it succeeded