Skip to content

Update snapshot for NavigatorDataProvider test #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

hqhhuang
Copy link
Contributor

Bug/issue #, if applicable: rdar://134589698

Summary

I don’t think we saved the intended snapshot for the NavigatorDataProvider test.
The current snapshot has empty navigator data, but we are using it to test if the renderer contains the correct modified navigator data.

Testing

Unit test

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

@hqhhuang hqhhuang marked this pull request as ready for review August 23, 2024 21:41
@hqhhuang
Copy link
Contributor Author

@swift-ci test

Copy link
Member

@marinaaisa marinaaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run it and it looks great, thank you!

@hqhhuang hqhhuang merged commit 6fc174e into swiftlang:main Sep 3, 2024
1 check passed
@hqhhuang hqhhuang deleted the fix-navigator-data-provider-text branch September 3, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants