Skip to content

[6.1] Cherry-pick two last-minute PRs #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

QuietMisdreavus
Copy link
Contributor

@QuietMisdreavus QuietMisdreavus commented Nov 20, 2024

This PR cherry-picks two recent PRs that landed in main just after the release/6.1 branch was created.

cc @icanzilb @Kyome22

  • Explanation: Updates Package.swift to use URLs ending in .git, for consistency with other first-party Swift packages.
  • Scope: Minor update to package specification.
  • Issues: None
  • Original PRs: Fix the suffix of dependency urls in Package.swift #1073
  • Risk: Very low. The change updates URLs to an equivalent URL that resolves to the same dependency.
  • Testing: Automated testing has passed.
  • Reviewers: @d-ronnqvist

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@franklinsch
Copy link
Contributor

@QuietMisdreavus do we still need this PR?

@QuietMisdreavus
Copy link
Contributor Author

Yes. I was unfortunately OOO right when this was approved, and when i came back the branch was locked for the holiday. Thanks for the reminder; i'll merge this now.

@QuietMisdreavus QuietMisdreavus merged commit c2c3eeb into swiftlang:release/6.1 Dec 4, 2024
2 checks passed
@QuietMisdreavus QuietMisdreavus deleted the 6.1/backports branch December 4, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants