Keep external links to non-symbols in generated See Also sections #788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://116540790
Summary
Fix a bug where only links to external symbols were included in the generated See Also sections.
Dependencies
None
Testing
This can be tested using
bin/test-data-external-resolver
as an external resolver:DOCC_LINK_RESOLVER_EXECUTABLE
to thetest-data-external-resolver
pathDOCC_HTML_DIR
to swift-docc-render-artifact checkout path (/path/to/swift-docc-render-artifact/dist
)<doc://com.test.bundle/something>
For example, with an Article.md file in Something.docc:
# Article An article.
and a Root.md file:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/test
script and it succeeded[ ] Updated documentation if necessary