Merge pull request #669 from compnerd/static-dsym

Driver: do not create a dSYM bundle for static archives

Author: gottesmm

Sources/SwiftDriver/Jobs/Planning.swift

@@ -472,8 +472,18 @@ extension Driver {
 
     let linkJ = try linkJob(inputs: linkerInputs)
     addJob(linkJ)
-    guard targetTriple.isDarwin, debugInfo.level != nil
-    else {return }
+    guard targetTriple.isDarwin
+    else { return }
+
+    switch linkerOutputType {
+    case .none, .some(.staticLibrary):
+      // Cannot generate a dSYM bundle for a non-image target.
+      return
+
+    case .some(.dynamicLibrary), .some(.executable):
+      guard debugInfo.level != nil
+      else { return }
+    }
 
     let dsymJob = try generateDSYMJob(inputs: linkJ.outputs)
     addJob(dsymJob)

Tests/SwiftDriverTests/SwiftDriverTests.swift

@@ -3078,6 +3078,24 @@ final class SwiftDriverTests: XCTestCase {
       XCTAssertFalse(plannedJobs.contains { $0.kind == .generateDSYM })
     }
 
+    do {
+      var env = ProcessEnv.vars
+      // As per Unix conventions, /var/empty is expected to exist and be empty.
+      // This gives us a non-existent path that we can use for libtool which
+      // allows us to run this this on non-Darwin platforms.
+      env["SWIFT_DRIVER_LIBTOOL_EXEC"] = "/var/empty/libtool"
+
+      // No dSYM generation (-g -emit-library -static)
+      var driver = try Driver(args: [
+        "swiftc", "-target", "x86_64-apple-macosx10.15", "-g", "-emit-library",
+        "-static", "-o", "library.a", "library.swift"
+      ], env: env)
+      let jobs = try driver.planBuild()
+
+      XCTAssertEqual(jobs.count, 3)
+      XCTAssertFalse(jobs.contains { $0.kind == .generateDSYM })
+    }
+
     do {
       // dSYM generation (-g)
       var driver = try Driver(args: commonArgs + ["-g"])