Driver: do not create a dSYM bundle for static archives #669
Conversation
|
@swift-ci please test |
I'm really confused by this error, this is the enum type: |
enum MyEnum {
case A
case B
}
let optionalEnum: MyEnum?
switch optionalEnum {
case .A:
case .B:
case .none:
}where before you needed switch optionalEnum {
case .some(.A):
case .some(.B):
case .none:
}Edit: to combat confusion, I think there is actually a warning if you add .none to an enum. Or maybe it's if you don't reference it directly |
Ah, didn't notice the optional. Thanks, @cltnschlosser! |
|
@swift-ci please test |
|
@swift-ci test |
|
compnerd and I looked at the error and the correct answer is indeed 3. You can see this since in the old driver this is how we used to emit it in terms of jobs: |
|
@swift-ci test |
|
This is the swift-driver version of swiftlang/swift#37526 |
|
@artemcm what do you think about the Linux failure here? It doesn't find lib tool. |
Creation of a dSYM bundle for a static library is not supported. Do not create a job to create a dSYM bundle for a static library.
|
@swift-ci please test |
| // As per Unix conventions, /var/empty is expected to exist and be empty. | ||
| // This gives us a non-existent path that we can use for libtool which | ||
| // allows us to run this this on non-Darwin platforms. | ||
| env["SWIFT_DRIVER_LIBTOOL_EXEC"] = "/var/empty/libtool" |
There was a problem hiding this comment.
Hmm, I expected this to work.
Co-authored-by: Artem Chikin <[email protected]>
|
@swift-ci please test |
|
I am going to cherry-pick this to 5.5. |
|
@gottesmm ugh, I forgot to do that, thank you so much for staying on top of that! |
Creation of a dSYM bundle for a static library is not supported. Do not
create a job to create a dSYM bundle for a static library.