Driver: do not generate a dSYM bundle for static archives #37526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
CodaFi
approved these changes
May 20, 2021
|
Build failed |
|
Build failed |
compnerd
force-pushed
the
dsym-static
branch
2 times, most recently
from
84e4937 to
3dfbcfa
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test Windows platform |
|
@swift-ci please test |
When building a static library with debug information, do not create a dSYM generation job as it cannot be executed on a non-image target. This is important for the case where the single invocation is both the compile and link job. This was detected in conjunction with @gottesmm.
|
@swift-ci please test Windows platform |
|
@swift-ci please test macOS |
|
@swift-ci please test Linux |
|
Windows failures are related to concurrency. I don't think it should stop this from going in. |
|
The Windows failures are not related (tests are coming online due to LLVM changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a static library with debug information, do not create a
dSYM generation job as it cannot be executed on a non-image target.
This is important for the case where the single invocation is both the
compile and link job.
This was detected in conjunction with @gottesmm
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.