Skip to content

Add support for reading fine-grained source file dependency graphs #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2020

Conversation

owenv
Copy link
Contributor

@owenv owenv commented May 14, 2020

This just ports over the parts of the source file fine-grained dependency graph the driver cares about. I just called it SourceFileDependencyGraph because I assume we don't intend to support the older dependency system. I'm still learning how all this works in the C++ driver, so I'm open to feedback on the API and approach!

@owenv owenv force-pushed the source-file-dep-graph branch 2 times, most recently from a63f4e2 to d502361 Compare May 14, 2020 01:20
@owenv
Copy link
Contributor Author

owenv commented May 14, 2020

@swift-ci test

Clean up incremental compilation test inputs

Re-run swift test --generate-linuxmain
@owenv owenv force-pushed the source-file-dep-graph branch from d502361 to 4b724c9 Compare May 14, 2020 02:10
@owenv
Copy link
Contributor Author

owenv commented May 14, 2020

@swift-ci test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic to me. Any thoughts, @davidungar ?

@DougGregor
Copy link
Member

@swift-ci test

@DougGregor DougGregor merged commit 573a322 into swiftlang:master May 14, 2020
@davidungar
Copy link
Contributor

Looks good! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants