remove unnecessary TSCLibc dependency
#1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
artemcm
approved these changes
Feb 1, 2022
These modules did not use any of the `TSCLibc` interfaces but relied on the module's re-exported libc import. Simply inline that and remove the dependency on `TSCLibc`. On Linux and Apple platforms, this does not have much impact, however, Windows does not support static linking of Swift content yet. As a result, this avoids an unnecessary dynamic library being linked and increasing the dirty memory of the process.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modules did not use any of the
TSCLibcinterfaces but relied onthe module's re-exported libc import. Simply inline that and remove the
dependency on
TSCLibc. On Linux and Apple platforms, this does nothave much impact, however, Windows does not support static linking of
Swift content yet. As a result, this avoids an unnecessary dynamic
library being linked and increasing the dirty memory of the process.