Skip to content

Driver performance improvements (profile test/Driver/response-file.swift) #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cltnschlosser
Copy link
Contributor

Big change is:

Remove job from build keys. Saves encoding and decoding the jobs

The runtime of the following (in release build) went from 2.27 minutes to 2.29 seconds (notice the change in units!!!)
// RUN: %{python} -c 'for i in range(500001): print("-DTEST5_" + str(i))' > %t.5.resp
// RUN: not %target-swiftc_driver %s @%t.5.resp -Xfrontend -debug-crash-immediately 2>&1

The runtime of the following (in release build) went from 2.27 minutes to 2.29 seconds (notice the change in units!!!)
// RUN: %{python} -c 'for i in range(500001): print("-DTEST5_" + str(i))' > %t.5.resp
// RUN: not %target-swiftc_driver %s @%t.5.resp -Xfrontend -debug-crash-immediately 2>&1
Copy link
Contributor

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, it should make working with the integration tests much less annoying!

@owenv
Copy link
Contributor

owenv commented May 17, 2020

@swift-ci test

@DougGregor DougGregor merged commit 28563cb into swiftlang:master May 19, 2020
@cltnschlosser cltnschlosser deleted the cs_largeResponseFileRuntime branch November 2, 2020 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants