Revert "Refactor job response file handling to (hopefully) prevent regressions." #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
artemcm
requested changes
Mar 23, 2022
|
Thanks for fixing this @artemcm ! |
|
Thanks for finding a fix without needing to revert it! |
|
@swift-ci please test source compatibility |
|
(Sorry, trying to test out a theory) |
|
Re-closing, sorry for the noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1036
cc: @allevato @artemcm
Sorry that I have to revert this PR. This PR seems to have caused conflicts with our internal repo. We'll investigate how to resolve them and merge this again.