Print commands required to explicitly build module dependencies. #104
+625
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have a swift style guide akin to: https://llvm.org/docs/CodingStandards.html ? |
artemcm
commented
May 18, 2020
|
As far as API design and naming questions: https://swift.org/documentation/api-design-guidelines/ For other stylistic decisions, this style guide is pretty close to standard library style, and should be preferred for this project as well IMO: https://google.github.io/swift |
Sources/SwiftDriver/Dependency Scanning/ModuleDependencyBuildGeneration.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftDriver/Dependency Scanning/ModuleDependencyBuildGeneration.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftDriver/Dependency Scanning/ModuleDependencyBuildGeneration.swift
Show resolved
Hide resolved
Sources/SwiftDriver/Dependency Scanning/ModuleDependencyBuildGeneration.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftDriver/Dependency Scanning/ModuleDependencyBuildGeneration.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftDriver/Dependency Scanning/ModuleDependencyBuildGeneration.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftDriver/Dependency Scanning/ModuleDependencyBuildGeneration.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftDriver/Dependency Scanning/ModuleDependencyBuildGeneration.swift
Outdated
Show resolved
Hide resolved
artemcm
force-pushed
the
ExplicitModuleDependencyJobGen
branch
2 times, most recently
from
bbaf4b9 to
e3aef4d
Compare
owenv
reviewed
May 18, 2020
Sources/SwiftDriver/Dependency Scanning/ModuleDependencyGraph.swift
Outdated
Show resolved
Hide resolved
artemcm
force-pushed
the
ExplicitModuleDependencyJobGen
branch
from
e3aef4d to
412c1f8
Compare
DougGregor
reviewed
May 19, 2020
Sources/SwiftDriver/Dependency Scanning/ModuleDependencyBuildGeneration.swift
Outdated
Show resolved
Hide resolved
DougGregor
approved these changes
May 19, 2020
Sources/SwiftDriver/Dependency Scanning/ModuleDependencyBuildGeneration.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftDriver/Dependency Scanning/ModuleDependencyBuildGeneration.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftDriver/Dependency Scanning/ModuleDependencyBuildGeneration.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftDriver/Dependency Scanning/ModuleDependencyBuildGeneration.swift
Outdated
Show resolved
Hide resolved
artemcm
force-pushed
the
ExplicitModuleDependencyJobGen
branch
from
412c1f8 to
d1b8f88
Compare
|
@swift-ci test |
DougGregor
requested changes
May 20, 2020
artemcm
force-pushed
the
ExplicitModuleDependencyJobGen
branch
from
d1b8f88 to
73fbc9b
Compare
artemcm
changed the title
artemcm
force-pushed
the
ExplicitModuleDependencyJobGen
branch
from
73fbc9b to
60197c8
Compare
owenv
requested changes
May 20, 2020
artemcm
force-pushed
the
ExplicitModuleDependencyJobGen
branch
from
60197c8 to
20234bb
Compare
|
@owenv, thanks for catching this. |
owenv
reviewed
May 20, 2020
artemcm
force-pushed
the
ExplicitModuleDependencyJobGen
branch
from
20234bb to
e29950d
Compare
DougGregor
reviewed
May 21, 2020
|
@swift-ci please test |
This PR resurrects swiftlang#47 and builds on top of it. Adds new flag -driver-print-module-dependencies-jobs to instruct the driver to scan for dependencies and generate build jobs for each dependent Swift or C module. At present, this WIP does the following: - Invoke the Swift frontend Fast Dependency Scanner to prescan for dependencies. - Construct a Module Dependency Graph from the dependency scanner's JSON output. - Generate and print build jbos for each dependent module. Next Steps: Actually have the driver schedule and execute the dependent module build jobs ahead of time, eliminating the need to re-build those modules when it tries to import them.
artemcm
force-pushed
the
ExplicitModuleDependencyJobGen
branch
from
e29950d to
d8c6c24
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
owenv
approved these changes
May 21, 2020
DougGregor
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resurrects #47 and builds on top of it.
Adds new flag
-driver-print-module-dependencies-jobsto instruct the driver to scan for dependencies and generate build jobs for each dependent Swift or C module.At present, this WIP does the following:
Next Steps:
I am new to writing Swift so I encourage reviewers to nit-pick with extreme prejudice.