Skip to content

README: document how to build swift-driver on Windows #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

compnerd
Copy link
Member

Although the toolchain distribution builds use CMake to build on Windows
(for bootstrapping the toolchain distribution), the development of
swift-driver on Windows requires building with swift-package-manager.
Update the documentation to explain how to build on Windows.

Although the toolchain distribution builds use CMake to build on Windows
(for bootstrapping the toolchain distribution), the development of
swift-driver on Windows requires building with swift-package-manager.
Update the documentation to explain how to build on Windows.
@compnerd
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@cltnschlosser cltnschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I’ll have to try this out sometime. I gave up trying to build the toolchain on windows when I tried a few months back.

does swift test with those additional parameters, also work?

@compnerd
Copy link
Member Author

compnerd commented Apr 10, 2022

Ah, alas I forgot that I never documented this in the README :-(. The swift driver bring up was all done with swift-package-manager (the only time to use CMake is when you are first building yourself a toolchain). Yes, swift-test works with the additional arguments ... in theory.

Currently, there have been some regressions (some of my own doing 😬). I would like to fix up the issues which I have caused with the recent rework of Path from swift-tools-support-core. There were a few other failures that I found due to the toolchain packaging having issues which I was unaware of. swiftlang/swift-installer-scripts#116 should help resolve the missing swift-api-digester which is required for the test suite. After that, there are ~14 failures due to path mismatches which I need to fix up to make swift-driver work with the latest swift-tools-support-core. Subsequently, there are 2 failures that I do not yet understand in SwiftDriverTests.testSupportedFeatureJson.

I would like to add that all of the 24 failures are regressions and that previously swift test with the documented flags would have given you a clean bill of health.

Hopefully @shahmishal will be able to help get CI enabled for Windows here.

Update: swiftlang/swift-installer-scripts#117 should resolve the 2 other failures. So, for now, just pin swift-tools-support-core at 58bb41c30c02ea4f46afdd31d90339ed0058c35f. With the other pending changes, you should even be able to run the test suite with swift test (given the documented arguments).

@compnerd compnerd merged commit 5cfd593 into swiftlang:main Apr 11, 2022
@compnerd compnerd deleted the builds branch April 11, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants