Port to Android #111
Merged
Port to Android #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlanhaskins
approved these changes
May 24, 2020
|
@swift-ci please test |
|
LGTM. Is the generic Unix toolchain (really only tested in Linux thus far) really good enough for Android? Or are there more fixes coming? |
|
I think it's mostly good enough, as the Termux app that I'm using on Android creates a similar environment, but I'll look into why I had to set the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Swift master natively on Android, also had to add the
swiftcpath below to myPATHfor the tests to find it. Most tests pass with the following commands (the_GNU_SOURCEflag has to do with building TSC on Android):