Skip to content

[5.7] Remove incrementalCompilationState from ToolExecutionDelegate. #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2022
Merged

[5.7] Remove incrementalCompilationState from ToolExecutionDelegate. #1123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Sources/SwiftDriver/Driver/Driver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1409,7 +1409,6 @@ extension Driver {
return ToolExecutionDelegate(
mode: mode,
buildRecordInfo: buildRecordInfo,
incrementalCompilationState: incrementalCompilationState,
showJobLifecycle: showJobLifecycle,
argsResolver: executor.resolver,
diagnosticEngine: diagnosticEngine)
Expand Down
3 changes: 0 additions & 3 deletions Sources/SwiftDriver/Driver/ToolExecutionDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ import Glibc

public let mode: Mode
public let buildRecordInfo: BuildRecordInfo?
public let incrementalCompilationState: IncrementalCompilationState?
public let showJobLifecycle: Bool
public let diagnosticEngine: DiagnosticsEngine
public var anyJobHadAbnormalExit: Bool = false
Expand All @@ -53,13 +52,11 @@ import Glibc

@_spi(Testing) public init(mode: ToolExecutionDelegate.Mode,
buildRecordInfo: BuildRecordInfo?,
incrementalCompilationState: IncrementalCompilationState?,
showJobLifecycle: Bool,
argsResolver: ArgsResolver,
diagnosticEngine: DiagnosticsEngine) {
self.mode = mode
self.buildRecordInfo = buildRecordInfo
self.incrementalCompilationState = incrementalCompilationState
self.showJobLifecycle = showJobLifecycle
self.diagnosticEngine = diagnosticEngine
self.argsResolver = argsResolver
Expand Down
3 changes: 0 additions & 3 deletions Tests/SwiftDriverTests/ParsableMessageTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ final class ParsableMessageTests: XCTestCase {
let args : [String] = try resolver.resolveArgumentList(for: compileJob, forceResponseFiles: false)
let toolDelegate = ToolExecutionDelegate(mode: .parsableOutput,
buildRecordInfo: nil,
incrementalCompilationState: nil,
showJobLifecycle: false,
argsResolver: resolver,
diagnosticEngine: DiagnosticsEngine())
Expand Down Expand Up @@ -247,7 +246,6 @@ final class ParsableMessageTests: XCTestCase {
args = try resolver.resolveArgumentList(for: compileJob!, forceResponseFiles: false)
toolDelegate = ToolExecutionDelegate(mode: .parsableOutput,
buildRecordInfo: nil,
incrementalCompilationState: nil,
showJobLifecycle: false,
argsResolver: resolver,
diagnosticEngine: DiagnosticsEngine())
Expand Down Expand Up @@ -325,7 +323,6 @@ final class ParsableMessageTests: XCTestCase {
forceResponseFiles: false)
toolDelegate = ToolExecutionDelegate(mode: .parsableOutput,
buildRecordInfo: nil,
incrementalCompilationState: nil,
showJobLifecycle: false,
argsResolver: resolver,
diagnosticEngine: DiagnosticsEngine())
Expand Down