[5.7] New: Update incremental build hash to encode option arguments a… #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd ordering This reverts commit 276e9dc.
|
@swift-ci please test |
artemcm
approved these changes
Jul 11, 2022
nkcsgexi
approved these changes
Jul 13, 2022
|
Thanks @nkcsgexi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #1128 to release branch
Explanation: Before this change, changing the argument to an option which affects incremental builds, or the relative ordering of multiple options affecting incremental builds won't correctly rebuild all of the sources. Update the argsHash computation to take order and arguments into account.
Scope: Affects incremental builds after driver CLI arguments are changed manually or by a build system.
Risk: Low
Reviewers: @artemcm
Testing: Added unit test coverage to the incremental builds suite
Issue: rdar://96556787