Skip to content

IncrementalDependencyAndInputSetup.swift: fix mutability warning #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Jan 5, 2023

This is a warning that's currently caused by priors using a var binding:

IncrementalCompilation/IncrementalDependencyAndInputSetup.swift:281:17: warning: variable 'priors' was never mutated; consider changing to 'let' constant
      guard var priors = computeGraphAndInputsInvalidatedByExternals() else {
            ~~~ ^
            let

This is the warning that's currently caused by `priors` using a `var` binding:
```swift
IncrementalCompilation/IncrementalDependencyAndInputSetup.swift:281:17: warning: variable 'priors' was never mutated; consider changing to 'let' constant
      guard var priors = computeGraphAndInputsInvalidatedByExternals() else {
            ~~~ ^
            let
```
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaxDesiatov

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test Linux

@MaxDesiatov MaxDesiatov merged commit 7964ae6 into main Jan 6, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/fix-priors-warning branch January 6, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants