Skip to content

Link runtime compatibility libs on darwin if needed #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Jun 18, 2020

This also fixes Interpreter/objc_class_properties_runtime from the integration tests

@owenv
Copy link
Contributor Author

owenv commented Jun 18, 2020

@swift-ci test

@owenv owenv requested a review from DougGregor June 18, 2020 03:48
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this; this looks good as a direct port of the logic from the C++ driver. It does make me wonder if we should get this information from the frontend directly. For example, -print-target-info given the target triple will tell us runtime compatibility version, resource directory, etc., and can certainly be extended. For example:

  "target": {
    "triple": "arm64-apple-ios13.0",
    "unversionedTriple": "arm64-apple-ios",
    "moduleTriple": "arm64-apple-ios",
    "swiftRuntimeCompatibilityVersion": "5.1",
    "librariesRequireRPath": false
  },

@owenv
Copy link
Contributor Author

owenv commented Jun 18, 2020

@DougGregor that's a good idea I hadn't thought of, it would be nice to avoid duplication between the driver & frontend. I'll look into integrating -print-target-info in a follow-up, I think it'll be easier now that there are a few unit tests to verify against.

@owenv owenv merged commit 64f3fcb into swiftlang:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants