Skip to content

Conform VirtualPath to CustomStringConvertible #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vbergae
Copy link
Contributor

@vbergae vbergae commented Oct 13, 2019

Hi!

Just a PR to fix a really simple FIXME. Not sure if the FIXME will finally apply or keeping the attribute name is the desired solution. Any comment or suggestion to finish the PR is more than welcome :)

@harlanhaskins
Copy link
Contributor

Thanks for doing this! I am torn between "we should use the standard set of protocols" and "we should have this semantic property name that's very clear at the call site.

What if we added name back, but just as

var name: String { description }

@vbergae vbergae force-pushed the conform_virtualdevice_to_customstringconvertible branch from da9e53f to c8d4c7b Compare October 14, 2019 18:54
@vbergae
Copy link
Contributor Author

vbergae commented Oct 14, 2019

True, I felt something similar looking from callee point of view. Let's see if the current solution is a good compromise 😄

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I, too, like this better. name feels right semantically, but it's good to have CustomStringConvertible conformance. Thank you!

@DougGregor
Copy link
Member

@swift-ci please test and merge

@shahmishal
Copy link
Member

@swift-ci test

@shahmishal
Copy link
Member

@swift-ci Please test

@DougGregor DougGregor merged commit fe68e4e into swiftlang:master Oct 16, 2019
DougGregor pushed a commit that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants