[5.9] Disable adding '-external-plugin-path' in integrated driver mode #1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
artemcm
approved these changes
May 8, 2023
nkcsgexi
approved these changes
May 8, 2023
DougGregor
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #1356 into
release/5.9Explanation: Detecting if
-external-plugin-pathshould be added or not is not reliable in "integrated driver" mode. In such cases the user should manually add them. This change just disable adding-external-plugin-pathifDriver.integratedDriveris true.Scope: Frontend arguments
Risk: Low. This just disabled a newly added functionality depending on the condition
Testing: Added a regression test case to verify
-external-plugin-pathis added automatically if the flag is on.Issue: rdar://109060298
Reviewer: Artem Chikin (@artemcm )