Make the DWARF version configurable. #1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test with swiftlang/swift#69254 |
|
test with swiftlang/swift#69254 |
DougGregor
approved these changes
Oct 18, 2023
| @@ -2308,7 +2308,24 @@ extension Driver { | |||
| diagnosticsEngine.emit(.error_argument_not_allowed_with(arg: fullNotAllowedOption, other: levelOption.spelling)) | |||
| } | |||
|
|
|||
| return DebugInfo(format: format, level: level, shouldVerify: shouldVerify) | |||
| // Determine the DWARF version. | |||
| var dwarfVersion: UInt8 = 4 | |||
There was a problem hiding this comment.
Usually we just use Int, but this is okay.
adrian-prantl
force-pushed
the
dwarf-version
branch
from
5c568d8 to
4900dda
Compare
|
test with swiftlang/swift#69254 |
|
test with swiftlang/swift#69254 |
This mirrors a similar change in the swift repository.
adrian-prantl
force-pushed
the
dwarf-version
branch
from
4900dda to
ac0ab85
Compare
|
test with swiftlang/swift#69254 |
|
test with swiftlang/swift#69254 |
artemcm
approved these changes
Oct 19, 2023
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors a similar change in the swift repository.