Skip to content

Fix tests to match behaviour expected with newest toolchain #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jul 1, 2020

Newest toolchains contain the swift --> swift-frontend rename so a couple of tests needed fixing up.

Newest toolchains contain the swift --> swift-frontend rename so a couple of tests needed fixing up.
@artemcm artemcm requested a review from DougGregor July 1, 2020 17:43
@artemcm
Copy link
Contributor Author

artemcm commented Jul 1, 2020

@swift-ci please test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! Can you fix up the README as well?

@artemcm
Copy link
Contributor Author

artemcm commented Jul 1, 2020

@swift-ci please test

@artemcm artemcm merged commit ea437d8 into swiftlang:master Jul 1, 2020
@JhonnyBillM
Copy link
Contributor

Hello, when testing in my machine I get could not decode frontend target info; compiler driver and frontend executables may be incompatible.
I have been testing in macOS 10.15.6 with Xcode 11.6 (11E708), Xcode 12.0 beta 6 (12A8189n) and the latest Swift 5.3 Snapshot, in any of those scenarios I have a swift-frontend as mentioned in the README; I am a little bit confused by this, any idea on what is the correct set up for the Driver to find the correct target info?

Cc @owenv since you worked on the error handling/reporting

Thanks in advance!

@owenv
Copy link
Contributor

owenv commented Sep 5, 2020

@JhonnyBillM right now, swift-driver requires a trunk development snapshot from swift.org, the 5.3 snapshots are missing some more recent required changes. I'd try updating that first, and I'll add a note to the README to clarify that requirement. If that isn't enough to get things working, do you mind posting in the Development sections of the forums and we can debug more there?

@artemcm artemcm deleted the FixDriverTrunk branch January 20, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants