Compute and append -file-compilation-dir when -g options are used #1557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwiftDriver should compute `-file-compilation-dir` when debug info is used. This can avoid `swift-frontend` to compute its own compilation directory, which can cause `swift-frontend` to generate different code with the same command if current working directory changed.
|
@swift-ci please test |
adrian-prantl
approved these changes
Mar 9, 2024
cachemeifyoucan
added a commit
to cachemeifyoucan/swift-driver
that referenced
this pull request
Mar 12, 2024
A follow-up to swiftlang#1557 that when caching is enabled and using the scanner prefix mapping option to canonicalize the path, make sure the path passed via `-file-compilation-dir` is remapped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftDriver should compute
-file-compilation-dirwhen debug info is used. This can avoidswift-frontendto compute its own compilation directory, which can causeswift-frontendto generate different code with the same command if current working directory changed.