Skip to content

[6.0] Stop adding '-external-plugin-path' to SDK directories #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Mar 29, 2024

Cherry-pick #1573 into release/6.0

  • Explanation: Apple SDK plugins are placed under '{}.platform/Developer/usr' directories, not in the SDK directory. Adding nonexisting paths can be confusing.
  • Scope: Frontend arguments for Darwin platforms
  • Risk: Low. The paths were never used and non-exisitent
  • Testing: Updated regression test cases
  • Issues: rdar://121451763
  • Reviewer: Doug Gregor (@DougGregor)

Apple SDK plugins are placed under '{}.platform/Developer/usr' directories,
not in the SDK directory. Adding nonexisting paths can be confusing.

rdar://121451763
(cherry picked from commit a5cc373)
@rintaro
Copy link
Member Author

rintaro commented Mar 29, 2024

@swift-ci Please test

@rintaro rintaro merged commit 084e525 into swiftlang:release/6.0 Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants