Skip to content

[6.0][Option] Support MultiArg options #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cachemeifyoucan
Copy link
Contributor

Explanation: Add MultiArg support in swift-driver in preparation for landing swiftlang/swift#73601
Scope: This supports generating Options.swift from swift after add new arguments with MultiArg.
Original PR: #1609
Reviewer: @owenv @artemcm
Test: UnitTest

Teach SwiftOption to handle MultiArg options, including generating
Options from Options.td, etc. Even the only MultiArg option in
swift is a NoDriver option, still teach the OptionTable to parse such
options to future proof the implementation.

(cherry picked from commit 62c300b)
@cachemeifyoucan cachemeifyoucan requested a review from a team May 15, 2024 16:07
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan cachemeifyoucan changed the title [Option] Support MultiArg options [6.0][Option] Support MultiArg options May 15, 2024
@cachemeifyoucan cachemeifyoucan merged commit b99ffe3 into swiftlang:release/6.0 May 15, 2024
3 checks passed
@cachemeifyoucan cachemeifyoucan deleted the eng/PR-multi-arg-support-swift-6.0 branch May 15, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants