[cmake] Set up rpath for macOS binaries #1732
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rpath was not set for macOS binaries, resulting in binaries that needed post-build modifications to be runnable. This change sets the rpath for every binary built and fixes the installation folders for Swift libraries.
finagolfin
reviewed
Nov 20, 2024
| LIBRARY DESTINATION lib | ||
| RUNTIME DESTINATION bin) | ||
| set_target_properties(SwiftDriverExecution PROPERTIES | ||
| INSTALL_RPATH "$<$<PLATFORM_ID:Darwin>:@loader_path/../pm/llbuild>") |
There was a problem hiding this comment.
This shouldn't be needed, since there's another copy in @executable_path/../lib/swift/macosx. I've already submitted a pull to remove this copy, swiftlang/swift#77647.
There was a problem hiding this comment.
It depends on how swift-llbuild is built, but after further discussions, it seems lib/swift/macosx is the wrong directory for dynamic libraries and they should be in lib instead. I am closing this PR for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rpath was not set for macOS binaries, resulting in binaries that needed post-build modifications to be runnable. This change sets the rpath for every binary built and fixes the installation folders for Swift libraries.