[Caching] Invalidate built module if missing from CAS #1789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
akyrtzi,
owenv,
benlangmuir and
artemcm
|
@swift-ci please test |
owenv
approved these changes
Jan 31, 2025
cachemeifyoucan
changed the title
cachemeifyoucan
force-pushed
the
eng/PR-135718227
branch
from
4348332 to
bd22a96
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
artemcm
approved these changes
Jan 31, 2025
For swift caching build, swift-frontend only reads from CAS for inputs for full build reproducibility. In this case, if the CAS is removed, we need to treat the modules as missing from CAS and rebuild them, even if the version on disk appears to pass the up-to-date check. rdar://135718227
cachemeifyoucan
force-pushed
the
eng/PR-135718227
branch
from
bd22a96 to
77ffaa2
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For swift caching build, swift-frontend only reads from CAS for inputs for full build reproducibility. In this case, if the CAS is removed, we need to treat the modules as missing from CAS and rebuild them, even if the version on disk appears to pass the up-to-date check.
rdar://135718227