Allow module aliases to be raw identifiers. #1836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the companion to the frontend changes for SE-0451 in swiftlang/swift#76636. The first component of a `-module-alias` flag is allowed to be a raw identifier (without the backticks), which allows for uses like the following: ``` import `//some/module:name` ``` The *target* of the alias (the actual module name) must still be a valid Swift identifier, since that corresponds to file system artifacts that need stricter naming conventions.
|
@swift-ci please test |
|
Oh this will be so much nicer for bazel projects! ❤️ |
artemcm
approved these changes
Mar 24, 2025
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion to the frontend changes for SE-0451 in swiftlang/swift#76636. The first component of a
-module-aliasflag is allowed to be a raw identifier (without the backticks); for example,-module-alias //some/module:name=ActualModuleNameallows users to write this:The target of the alias (the actual module name) must still be a valid Swift identifier, since that corresponds to file system artifacts that need stricter naming conventions.