[Explicit Module Builds] Pass down pre-built module candidates to the -compile-module-from-interface jobs #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… -compile-module-from-interface jobs
|
@swift-ci please test |
fengjixuchui
referenced
this pull request
in fengjixuchui/swift-driver
Jul 29, 2020
Merge pull request apple#186 from artemcm/CompiledCandidates
DougGregor
reviewed
Jul 29, 2020
| @@ -58,7 +58,7 @@ extension ModuleDependencyId: Codable { | |||
| public var moduleInterfacePath: String? | |||
|
|
|||
| /// The paths of potentially ready-to-use compiled modules for the interface. | |||
| var compiledModuleCandidates: [String]? | |||
| public var compiledModuleCandidates: [String]? | |||
There was a problem hiding this comment.
Incorporated in:
#181
Since it already heavily modifies the graph structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-scan-dependenciesnow emits ready-to-use binary module candidates that can be imported by the compiler, e.g. modules adjacent to .swiftinterface files or in prebuilt module dirs.When invoking
-compile-module-from-interface, pass down these module candidates so the compiler can emit forwarding modules to them, saving the effort of type-checking/serializing binary modules at all.Resolves rdar://problem/66243229