Skip to content

Adjust to simulator compiler-rt change #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

beccadax
Copy link
Contributor

Matches changes to legacy driver in swiftlang/swift#33148:

Previously, we packaged both the device and simulator versions of compiler-rt in a single static archive, relying on the fact that they used different architectures to differentiate between them. But Apple Silicon is now here to make us repay this technical debt. swiftlang/llvm-project#1553 separated the simulator versions of compiler-rt into libraries with different names; this PR adjusts Swift to match.

The compiler_rt static library for iOS simulator is now packaged in a separate static archive from the one for iOS devices. Adjust linker invocation to match.

Matches changes in rdar://66192830.
@beccadax
Copy link
Contributor Author

@swift-ci test

@beccadax
Copy link
Contributor Author

beccadax commented Jul 29, 2020

DOWNLOAD_DIR=swift-DEVELOPMENT-SNAPSHOT-2020-07-22-a

Tests won't pass until we're testing against at least 2020-07-26. (The host toolchain might even need to be updated—we'll see...)

@beccadax beccadax marked this pull request as draft July 29, 2020 23:52
@beccadax
Copy link
Contributor Author

beccadax commented Aug 1, 2020

@swift-ci test

4 similar comments
@beccadax
Copy link
Contributor Author

beccadax commented Aug 3, 2020

@swift-ci test

@artemcm
Copy link
Contributor

artemcm commented Aug 5, 2020

@swift-ci test

@artemcm
Copy link
Contributor

artemcm commented Aug 10, 2020

@swift-ci test

@artemcm
Copy link
Contributor

artemcm commented Aug 26, 2020

@swift-ci test

@shahmishal shahmishal closed this Oct 5, 2020
@shahmishal
Copy link
Member

The Swift project moved the default branch to main and deleted master branch, so GitHub automatically closed the PR. Please re-create the pull request with main branch.

More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants