Pass -use-static-resource-dir to frontend when linking statically #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
drexin
force-pushed
the
wip-static-resource-dir
branch
from
233028b to
f7efa44
Compare
|
@swift-ci test |
drexin
force-pushed
the
wip-static-resource-dir
branch
from
f7efa44 to
610991d
Compare
|
@swift-ci test |
|
@swift-ci test macos |
drexin
force-pushed
the
wip-static-resource-dir
branch
from
610991d to
d201490
Compare
|
@swift-ci test |
DougGregor
reviewed
Aug 5, 2020
There was a problem hiding this comment.
This looks correct, although I think we also want to pass this down to -print-target-info? With your fixes to the Swift compiler, we might be able to replace this driver's resource-dir computation with using the result of -print-target-info, which would be wonderful.
DougGregor
approved these changes
Aug 5, 2020
|
Yes, good point. I‘ll add it to the target info. |
drexin
force-pushed
the
wip-static-resource-dir
branch
from
d201490 to
1f1ed5f
Compare
|
@swift-ci test |
drexin
force-pushed
the
wip-static-resource-dir
branch
2 times, most recently
from
bf16f7f to
a2b269d
Compare
|
@swift-ci test |
drexin
force-pushed
the
wip-static-resource-dir
branch
from
a2b269d to
311ddd5
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci test macOS |
1 similar comment
|
@swift-ci test macOS |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler computes the resource folder based on its own executable path when it is not explicitly set, but it used to always pick the shared resource folder, because it did not have information about whether the binary will be statically or dynamically linked. This has been changed in swiftlang/swift#33168 and this PR adjusts the behavior to match that of the C++ implementation.