[Build Script Helper] Setup environment variables for the specified toolchain's executables #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chain executables If a toolchain is specified, set the search environment variable for each tool executable the driver cares about. The driver will then use this environment variable use to find the tool.
|
@swift-ci please test |
|
I ran into this because on Ubuntu 16.04, even with a specified toolchain, the driver could not locate some executables. Curiously, this did not happen on Ubuntu 18.04 or 20.04. I'm still trying to figure out why this specific version of Ubuntu breaks; but, regardless, I think this change is an improvement because it ensures that we do use the provided toolchain's executables, instead of relying on search paths and potentially accidentally using a wrong executable for any of these tools. |
nkcsgexi
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a toolchain is specified, set the search environment variable for each tool executable the driver cares about to ensure that the specified toolchain's specific version is used.