Fix .swiftsourceinfo output path when the build system provides a Project/ dir #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
commented
Aug 8, 2020
Comment on lines
-1807
to
-1818
| // If there is an output argument, derive the name from there. | ||
| if let outputPathArg = parsedOptions.getLastArgument(.o) { | ||
| let path = try VirtualPath(path: outputPathArg.asSingle) | ||
|
|
||
| // If the compiler output is of this type, use the argument directly. | ||
| if type == compilerOutputType { | ||
| return path | ||
| } | ||
|
|
||
| return try path.replacingExtension(with: type) | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this logic is no longer used due to improvements in the module output path computation since it was written. Removing it didn't introduce any regressions in the integration tests
There was a problem hiding this comment.
It looks like dead code to me, thanks!
|
@swift-ci test Linux |
artemcm
approved these changes
Aug 10, 2020
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the remaining source info integration test (Driver/sourceinfo_file.swift)