Remove unnecessary linux skip for test #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't need to be skipped on Linux, it works!
|
@swift-ci please test |
DougGregor
approved these changes
Oct 20, 2019
|
Hmmm. This might be a configuration issue, where we don't have the path to the toolchain |
Yeah, this is a bit weird. If you follow the Linux docker guide in the README on macOS (https://github.com/apple/swift-driver#preparing-a-linux-docker-for-debug) and run this branch you will see that all tests passes. If you change the test to something like I don't know what the configuration on the CI is, but if that is public we can compare it to the swift Dockerfile. |
|
@swift-ci please test |
|
Yes! Working now with the recent toolchain improvements |
|
Awesome! Great to see :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked for low-haning Linux tests to fix since I was already in that sphere, and I saw this test. It ran fine on my system. Better to have it run on Linux since it can! :)