[Toolchains] - look for tools relative to the executable path. #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JhonnyBillM
changed the title
harlanhaskins
previously requested changes
Oct 23, 2019
|
Just wanna make sure this does the right thing falling back @swift-ci please test |
JhonnyBillM
force-pushed
the
where-are-the-tools
branch
from
d2c9d61 to
e53c79b
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
DougGregor
reviewed
Oct 30, 2019
…pecific behavior. FIX - some typos and parameter names. Merge branch 'master' into where-are-the-tools
|
Conflicts everywhere! It'll be good to get this up-to-date and merged now that #25 is in. Thank you! |
|
@swift-ci please test |
DougGregor
approved these changes
Dec 15, 2019
|
@swift-ci please test |
|
I saw some tests failing on Linux in the main swift project too. I think this can be a CI configuration issue. |
|
@swift-ci please test |
DougGregor
dismissed
harlanhaskins’s stale review
All issues have been resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once swift-driver is installed in the Toolchain, we can look for tools right next to it's executable path, this help us to be more platform agnostic while locating the toolchain.
This is the first step in this direction, we will need to make this more robust to get rid of xcrun if possible, and get a proper linux implementation.
The other options are:
Shim LLVM's getMainExecutable method using
swift-lldb, and expose the API fromlldbSwifttotools-support-core, so other projects such asSwiftPMwould benefit from this.Try to implement something like LLVM's getMainExecutable method in
tools-support-core. But I don't think this is 100 % feasible right now; this should be implemented in some low-level library such asLLVM,swift-lldborFoundation, to maintain projects asSwiftPMandswift-driverplatform agnostic as possible.