Skip to content

Update isTopLevelOutput predicate #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Update isTopLevelOutput predicate #254

merged 1 commit into from
Sep 15, 2020

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Sep 14, 2020

  • canonical sib, raw sib, imported modules, and index data are always top level (as far as I know)
  • bitcode is top-level if it's the compiler output type (in other words, it's not being embedded)

This fixes:

  • Frontend/sil-primary-file-with-sib.swift
  • reproducible-builds/swiftc-emit-bc.swift
  • reproducible-builds/swiftc-emit-sib.swift
  • reproducible-builds/swiftc-emit-sibgen.swift

sib, rawsib, imported modules, and index data are always top level
bitcode is top-level if it's the compiler output type (in other words, it's not being embedded)
@owenv
Copy link
Contributor Author

owenv commented Sep 14, 2020

@swift-ci test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look correct to me, thank you!

@owenv owenv merged commit dc26337 into swiftlang:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants